(MODULES-9370) Raise Supported Puppet lower bound from 4.9.0 to 5.5.10 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
changed the title
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Are we tracking vscode recommendations per module?
There was a problem hiding this comment.
I think this is PDK-ified now?
| end | ||
|
|
||
| start_time_valid = time_valid?(manifest_hash['start_time']) | ||
| raise ArgumentError, "Invalid start_time value: #{manifest_hash['start_time']}" unless start_time_valid |
There was a problem hiding this comment.
I don't understand why these errors don't need to be decorated like _("Invalid start_time value...")
There was a problem hiding this comment.
TBH, neither do I? But rubocop isn't yelling in this case.
ThoughtCrhyme
approved these changes
Aug 2, 2019
ThoughtCrhyme
suggested changes
Aug 2, 2019
This commit begins the alignment process of the module to the core structure, updating the project files and turning on rubocop. Importantly, in this first commit, the rubocop violations are not addressed but are instead recorded in a TODO. They will be addressed in future commits.
This commit enforces rubocop on the tests but *not* on the actual code. This is to ensure that tests continue to pass and we have confidence that the changes do not introduce any regressions.
This commit removes shebangs from the spec test files as these cause rubocop to mark the files as `should be executable` and fail if the file was saved on windows - during checkout, those files are not marked executable due to differences in the permissions models on windows/unix.
ThoughtCrhyme
approved these changes
Aug 2, 2019
michaeltlombardi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the work by @florindragos in #86, this PR makes a few small changes to the actual files but largely just splits the commits to ensure only the tests or library code are being changed at a time to keep confidence that no regressions are introduced.