PIE-412 Add disabling splunk_hec feature #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splunk_hec is a classthat may have no external impact to Forge modules. This module is declared in 2 of 576 indexed public
|
bmjen
previously approved these changes
Jun 10, 2021
nam054
force-pushed
the
PIE-412-add-splunk-hec-disable-feature
branch
2 times, most recently
from
7c56d58
to
2e9637b
Compare
gsparks
reviewed
Jun 10, 2021
nam054
force-pushed
the
PIE-412-add-splunk-hec-disable-feature
branch
from
2e9637b
to
38e6ea3
Compare
gsparks
previously approved these changes
Jun 10, 2021
nam054
force-pushed
the
PIE-412-add-splunk-hec-disable-feature
branch
2 times, most recently
from
9d2b5ca
to
1c84e16
Compare
Added new parameter 'disabled' that can be set to disable sending reports. Default is set to false, meaning it will always run the report processor (setting to true will disable sending reports). Added unit testing for the new feature in misc_spec.rb and init_spec.rb Created splunk_hec_spec_helpers.rb for unit test helper functions.
nam054
force-pushed
the
PIE-412-add-splunk-hec-disable-feature
branch
from
1c84e16
to
2764f7b
Compare
RandomNoun7
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new parameter 'disabled' that can be set to disable sending
reports. Default is set to false, meaning it will always run the report
processor (setting to true will disable sending reports).
Added unit testing for the new feature in misc_spec.rb and init_spec.rb
Created splunk_hec_spec_helpers.rb for unit test helper functions.
Summary
Detailed Description
Checklist
[ ] Draft PR?
[ ] Ensure README is updated
[ ] Any changes to existing documentation
[ ] Anything new added
[ ] Link to external Puppet documentation
[ ] Tags
[ ] Unit Tests
[ ] Acceptance Tests
[ ] PR title is "(Ticket|Maint) Short Description"
[ ] Commit title matches PR title