(PIE-818) Allow Ignore System Certificate Store #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splunk_hec is a classthat may have no external impact to Forge modules. This module is declared in 2 of 578 indexed public
|
This change allows a user to provide a ca certificate file that overrides the system trusted certificate store entirely. Prior to this change, a ca certificate file provided to the `ssl_ca` parameter was only a supplement to the system certificates store. This could cause an issue where the system certificate store contained invalid certificates and would cause certificate validation of the splunk_hec end point to fail before the provided `ssl_ca` file was checked. This change fixes that bug by ensuring that only the provided file is used for verification.
RandomNoun7
force-pushed
the
PIE-818-ignore-system-cert-store
branch
from
9bfe375
to
1044ab8
Compare
nam054
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a user to provide a ca certificate file that
overrides the system trusted certificate store entirely.
Prior to this change, a ca certificate file provided to the
ssl_caparameter was only a supplement to the system certificates store. This
could cause an issue where the system certificate store contained
invalid certificates and would cause certificate validation of the
splunk_hec end point to fail before the provided
ssl_cafile waschecked.
This change fixes that bug by ensuring that only the provided file is
used for verification.
Summary
Detailed Description
Checklist
[ ] Draft PR?
[ ] Ensure README is updated
[ ] Any changes to existing documentation
[ ] Anything new added
[ ] Link to external Puppet documentation
[ ] Review Support Playbook for any needed updates
[ ] Tags
[ ] Unit Tests
[ ] Acceptance Tests
[ ] PR title is "(Ticket|Maint) Short Description"
[ ] Commit title matches PR title