Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-792) Send all facts to Splunk #170

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Jan 11, 2022

Summary

This PR adds the ability to collect all facts (including custom facts) by adding the special value all.facts to the collect_facts parameter. With the aforementioned special value configured, the optional facts_blacklist will be taken into consideration when collecting facts.

Detailed Description

  • Updated lib/puppet/indirector/facts/splunk_hec.rb to collect all facts when all.facts is in the collect_facts array.
  • Added optional parameter facts_blocklist.
  • Updated README.md.
  • Updated REFERENCE.md.
  • Updated CHANGELOG.md.

Checklist

[X] Ensure README is updated
[X] Any changes to existing documentation
[X] Anything new added
[X] Link to external Puppet documentation
[X] Review Support Playbook for any needed updates
[X] Acceptance Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner January 11, 2022 19:30
@puppet-community-rangefinder
Copy link

splunk_hec is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@coreymbe coreymbe linked an issue Jan 11, 2022 that may be closed by this pull request
@coreymbe coreymbe force-pushed the PIE-792-send_all_facts branch 4 times, most recently from 7e29c1b to 498d53a Compare January 13, 2022 01:25
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@RandomNoun7 RandomNoun7 merged commit 376e5fa into puppetlabs:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a way to send *all* facts
2 participants