(PIE-959) Fix splunk_hec_agent_only_node fact #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
splunk_hec_agent_only_nodefact was flawed, in that it improperly resolved to true on infrastructure nodes (compilers, replica). This is caused by the fact previously checking if there was a difference between the server settingand the current nodes certname.
Detailed Description
As compilers and replicas have Puppet Server running, but still report to the Primary the fact is incorrectly resolving to true, indicating the node is only running the Puppet agent.
The changes in this PR determines which OS the node is running, then will check the appropriate directory for the Puppet Server service file.
Checklist
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title