(PIE-1039) Update deprecated reports parameter

[coreymbe]

Summary

Prior to this commit, the suggestion of setting the splunk_hec::reports parameter to an empty string results in corrective changes as it removes puppetdb from the reports setting.

Detailed Description

The new logic in init.pp prevents the reports parameter from configuring anything before throwing an updated warning message suggesting to set the parameter to undef or remove it entirely. It then will continue with adding splunk_hec to puppet.conf via the ini_subsetting resource.

Checklist

[X] Ensure README is updated
[X] Anything new added
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

[puppet-community-rangefinder]

splunk_hec is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 578 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.