PIE-1047 Account for negative indicies #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pe_event_forwarding will soon have the ability to disable rbac event collection for performance reasons. The is denoted in the index file with a -1 value. We need to cover the case where rbac events are enabled in splunk_hec but disabled in pe_event_forwarding. This check will skip indicies with negative values.
gsparks
force-pushed
the
PIE-1047_check_for_negative_indices
branch
from
77cc1a3
to
32e80ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pe_event_forwarding will soon have the ability to disable rbac event
collection for performance reasons. The is denoted in the index file
with a -1 value. We need to cover the case where rbac events are
enabled in splunk_hec but disabled in pe_event_forwarding. This check
will skip indicies with negative values.
Summary
Detailed Description
Checklist
[ ] Draft PR?
[ ] Ensure README is updated
[ ] Any changes to existing documentation
[ ] Anything new added
[ ] Link to external Puppet documentation
[ ] Review Support Playbook for any needed updates
[ ] Tags
[ ] Unit Tests
[ ] Acceptance Tests
[ ] PR title is "(Ticket|Maint) Short Description"
[ ] Commit title matches PR title