Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIE-1032 Account for configured confdirs #180

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Mar 8, 2022

The init.pp now accounts for customized confdirs from the
pe_event_forwarding module and places the proc files within the correct
directories.

Summary

Detailed Description

Checklist

[ ] Draft PR?
[ ] Ensure README is updated
[ ] Any changes to existing documentation
[ ] Anything new added
[ ] Link to external Puppet documentation
[ ] Review Support Playbook for any needed updates
[ ] Tags
[ ] Unit Tests
[ ] Acceptance Tests
[ ] PR title is "(Ticket|Maint) Short Description"
[ ] Commit title matches PR title

@nam054 nam054 requested a review from a team as a code owner March 8, 2022 21:26
@puppet-community-rangefinder
Copy link

splunk_hec is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@nam054 nam054 force-pushed the PIE-1032-update-confdir branch 2 times, most recently from dfd6b13 to c29d632 Compare March 8, 2022 22:06
@coreymbe coreymbe assigned coreymbe and unassigned coreymbe Mar 9, 2022
Copy link
Contributor

@coreymbe coreymbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this is currently written will only work when a user has configured pe_event_forwarding::confdir. Below is a proposed alternative method to determine the confdir that I've tested and confirmed works.

    if $pe_event_forwarding::confdir != undef {
      $confdir_base_path = $pe_event_forwarding::confdir
    }
    else {
      $confdir_base_path = pe_event_forwarding::base_path($settings::confdir, undef)
    }

The init.pp now accounts for customized confdirs from the
pe_event_forwarding module and places the proc files within the correct
directories.
Copy link
Contributor

@coreymbe coreymbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coreymbe coreymbe merged commit 6c4760b into puppetlabs:main Mar 10, 2022
@nam054 nam054 deleted the PIE-1032-update-confdir branch March 10, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants