Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PE-33667) Add SSL config options for FIPS #186

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Apr 18, 2022

Summary

Currently Puppet::SSL::SSLContext defaults are loaded when utilizing splunk_hec as a Puppet subcommand (i.e. metrics collection). As a result self-signed certificates are unable to be verified and CRL checks occur.

Detailed Description

This commit adds the option to flip verify_peer as well as certificate_revocation to false (defaulting to true) within the module so the options are passed in when the POST request is made.

Checklist

[X] Ensure README is updated
[X] Any changes to existing documentation
[X] Anything new added
[X] Review Support Playbook for any needed updates
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@puppet-community-rangefinder
Copy link

splunk_hec is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

gsparks
gsparks previously approved these changes Apr 19, 2022
@coreymbe coreymbe marked this pull request as ready for review April 20, 2022 00:07
@coreymbe coreymbe requested a review from a team as a code owner April 20, 2022 00:07
@gsparks gsparks merged commit ff17f93 into puppetlabs:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants