(PIE-1289) Event Filtering Bug Fix #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreymbe
force-pushed
the
PIE-1289-event_filtering_bug
branch
from
b049fd0
to
2a6300d
Compare
coreymbe
force-pushed
the
PIE-1289-event_filtering_bug
branch
from
2a6300d
to
48b876b
Compare
actowery
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While setting up rspec tests I found that filtering does not work for
pe-consoleandcode-manager. This is a result of the processor script looking forsplunk_hecsettings namedpe-console_data_filterandcode-manager_data_filterwhen the template file for settings has the them namedpe_console_data_filterandcode_manager_data_filter.Detailed Description
templates/splunk_hec.yaml.eppwith correct setting names.pe-consoleevents:spec/acceptance/events_processor_spec.rbspec/spec_helper_acceptance_local.rb.github/workflows/integration_test.ymlto test on PE LTS.Checklist
[X] Acceptance Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title