Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1300) Puppet 8 Compatibility #200

Merged
merged 1 commit into from
May 5, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Apr 28, 2023

Summary

Detailed Description

  • PDK Update:

    • metadata.json
    • .devcontainer/devcontainer.json
    • .rubocop.yml
    • .pdkignore
    • Rakefile
    • Gemfile
  • Rubocop Changes:

    • lib/puppet/indirector/facts/splunk_hec.rb
    • spec/spec_helper_acceptance_local.rb
  • Lint Changes:

    • manifests.init.pp
    • plans/acceptance/pe_server_setup.pp
    • plans/acceptance/provision_machines.pp
    • plans/examples/apply_example.pp
    • plans/examples/result_example.pp

Maint Changes:

  • metadata.json

    • Added Puppet 8 / Updated supported OS list.
  • .github/workflows/integration_test.yml

    • Add puppet8-nightly.
    • Removed Honeycomb steps.
  • .github/workflows/ci.yml

    • Refactored as it was using deprecated action-litmus_spec repo.
  • spec/classes/init_spec.rb

    • Removed MockFunction of pe_event_forwarding::base_path.

Ruby 3 Changes

  • spec/support/unit/reports/splunk_hec_spec_helpers.rb
    • Utilize kwargs for Puppet::Transaction::Event.new.

Checklist

[X] Acceptance Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner April 28, 2023 23:44
@coreymbe coreymbe force-pushed the PIE-1300-puppet_8_support branch 2 times, most recently from 1d877c0 to 7d62357 Compare May 2, 2023 18:04
@coreymbe coreymbe force-pushed the PIE-1300-puppet_8_support branch from 7d62357 to 07d112e Compare May 3, 2023 19:42
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@actowery actowery merged commit c6be66b into puppetlabs:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants