Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-1104) Disable facts and reports #205

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

coreymbe
Copy link
Contributor

@coreymbe coreymbe commented Aug 21, 2023

Summary

This PR ensures that settings added to puppet.conf are removed when splunk_hec::disabled to set to true.

Detailed Description

  • Update manifests/init.pp to ensure settings are removed from puppet.conf when disabled is true.
  • Added unit tests to spec/classes/init_spec.rb
  • Generated updates for REFERENCE.md.
  • Add changes to CHANGELOG.md.

Checklist

[X] Any changes to existing documentation
[X] Unit Tests
[X] PR title is "(Ticket|Maint) Short Description"
[X] Commit title matches PR title

@coreymbe coreymbe requested a review from a team as a code owner August 21, 2023 20:01
@coreymbe coreymbe force-pushed the PIE-1104-disabled_true branch 3 times, most recently from 3f39432 to fdbd0ac Compare August 28, 2023 17:34
Copy link
Contributor

@actowery actowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@actowery actowery merged commit 2b6404a into puppetlabs:main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants