PIE-178 Multiple Metrics in stdin #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this we assumed we would receive parsable json on standard in from the metrics executable regardless of number of systems involved. Instead it would output a json hash for each server and not attempt to combine them into a valid array. This converts any hash received on STDIN into an array of hashes (even if its just an array of 1).
bmjen
suggested changes
Dec 6, 2019
lib/puppet/application/splunk_hec.rb
Outdated
| @@ -57,9 +57,15 @@ def upload_report(data, _sourcetype) | |||
| end | |||
|
|
|||
| def main | |||
| data = JSON.parse(STDIN.read) | |||
| datainput = STDIN.read | |||
There was a problem hiding this comment.
Is the string read in from STDIN always going to be in the right format? Do we have to wrap this in a rescue block to catch a ruby exception on bad input?
There was a problem hiding this comment.
Latest commit adds a rescue block if we don't get anything on stdin, also checking that we get valid json before beginning to do anything else, so we can inform users of basic error states
added 2 commits
December 11, 2019 12:15
We know we might not get valid json all the time, but we should be getting something.
Also is more explicit about which exceptions we're handling (standard)
bmjen
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this we assumed we would receive parsable json on standard in from the metrics executable regardless of number of systems involved.
Instead it would output a json hash for each server and not attempt to combine them into a valid array. This converts any hash received on STDIN into an array of hashes (even if its just an array of 1).