Added the ability to change resources format #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created a ticket to enable prioritization. |
|
I"m not sure what has happened to the |
Prior to this change, Puppet 4 installs would fail due to lack of `job_id` or `code_id` in the report format. This change detects the report format version and adds those variables as needed to prevent errors.
(MAINT) Fix Puppet 4 Compatibility
Prior to this change the values for the resource parameters were hard coded to match Puppet Enterprise. This change enables the module to determine if it is in a PE environment or Open Source, and select the appropriate values to avoid errors. It also fixes a bug in the `requires` statements to account for path differences between PE and Open Source.
These being a hash is default Puppet behaviour, but this can make writing splunk queries very hard. Arrays are probably preferable
RandomNoun7
force-pushed
the
add_array_mode
branch
from
3901f48
to
9ea5beb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These being a hash is default Puppet behaviour, but this can make writing splunk queries very hard. Arrays are probably preferable but we likely don't want to change the default behaviour without a major release