Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PIE-431) Fix Open Source Compatibility #76

Merged

Conversation

RandomNoun7
Copy link
Contributor

Prior to this change the values for the of the resource parameters were
hard coded to match Puppet Enterprise.

This change enables the module to determine if it is in a PE environment
or Open Source, and select the appropriate values to avoid errors.

It also fixes a bug in the requires statements to account for path
differences between PE and Open Source.

@RandomNoun7 RandomNoun7 requested a review from a team as a code owner December 3, 2020 22:24
@puppet-community-rangefinder
Copy link

splunk_hec is a class

that may have no external impact to Forge modules.

This module is declared in 2 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@RandomNoun7
Copy link
Contributor Author

@southalc I took your original change and made a new PR with some slight changes and rebased to the current top of main. When this is merged I will close your previous PR (#56) in favor of this one.

@RandomNoun7 RandomNoun7 force-pushed the PIE-431-open-source-compatibility branch from cc3f0f6 to 6c77702 Compare December 4, 2020 15:49
@RandomNoun7 RandomNoun7 marked this pull request as draft December 4, 2020 18:10
Prior to this change the values for the resource parameters were
hard coded to match Puppet Enterprise.

This change enables the module to determine if it is in a PE environment
or Open Source, and select the appropriate values to avoid errors.

It also fixes a bug in the `requires` statements to account for path
differences between PE and Open Source.
@RandomNoun7 RandomNoun7 force-pushed the PIE-431-open-source-compatibility branch from 9e4ccbc to 61a7d70 Compare December 6, 2020 22:09
@RandomNoun7 RandomNoun7 marked this pull request as ready for review December 6, 2020 22:15
@gregohardy
Copy link
Contributor

+1

@gregohardy gregohardy merged commit d2bfa83 into puppetlabs:main Dec 7, 2020
@RandomNoun7 RandomNoun7 mentioned this pull request Dec 7, 2020
@RandomNoun7 RandomNoun7 deleted the PIE-431-open-source-compatibility branch December 7, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants