(PIE-455) Show the deprecation warning only when the report parameter #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splunk_hec is a classthat may have no external impact to Forge modules. This module is declared in 2 of 576 indexed public
|
RandomNoun7
reviewed
Dec 17, 2020
manifests/init.pp
Outdated
| if $enable_reports { | ||
| if $reports != '' { | ||
| if $reports == unset { |
There was a problem hiding this comment.
Is this supposed to be undef?
There was a problem hiding this comment.
So apparently you cant set a string param to undef unless it's optional?
There was a problem hiding this comment.
It was a typo though, you are correct.
has actually been defined.
RandomNoun7
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has actually been defined.