Merge pull request #255 from puppetlabs/release
Merge Release back to master
Merge pull request #256 from puppetlabs/maint_modsync_384f4c1
(maint) - modulesync 384f4c1
Merge pull request #258 from michaeltlombardi/modsync
(maint) modulesync cd884db Remove AppVeyor OpenSSL update on Ruby 2.4
(maint) Add support for agent-only testing
Previously the acceptance test suite had been modified to use test tiering and test mode switcher. However the spec acceptance helper method still expected a master to be present. This commit modifies the helper to only execute master provisioning steps if there is indeed a master specified in the hosts array.
(MODULES-6356) Fixes a problem still remaining from MODULES-2904
As described in MODULES-2904, installation fails with an array of SQL Admins. This was fixed in the use_discrete=true block (line 171-178. However the double quotes also needed to be removed from the list of accounts for the /SQLSYSADMINACCOUNTS switch parameter. This appears to be due to the arguments being interpretted literally, including the double quotes when doing account lookups. Without the fix, the only setting that works is /SQLSYSADMINACCOUNTS="BUILTIN\Administrators", all other settings (both local and domain accounts/groups) will fail, particularly those with whitespace.
Merge pull request #260 from puppetlabs/msync_MODULES-6339
(maint) modulesync 65530a4 Update Travis
Merge pull request #259 from puppetlabs/kreeuwijk-patch-1
(MODULES-6356) Fixes a problem still remaining from MODULES-2904
(FM-6605) Add CONTRIBUTING.MD to repository
Previosuly the contributing document was excluded from modsync. This commit enables the contributing document to be managed by modsync and adds the current document as of commit f0c21975ec for the modsync configs.
Merge pull request #262 from glennsarti/fm-6605
(FM-6605) Add CONTRIBUTING.MD to repository
(DOCUMENT-824) Update Changelog Format
This commit updates the changelog format to the more standardized KAC format: http://keepachangelog.com/en/1.0.0/ Ticket numbers were added to comments in the cases where they could be found.
Merge pull request #264 from RandomNoun7/tickets/master/DOCUMENT-824-…
…update_changelog_to_kac (DOCUMENT-824) Update Changelog Format
(MODULES-6281) Return Errors from T-SQL
The sqlserver_tsql resource does not handle errors returned from T-SQL statements properly. The errors come back from the query but unless the phrase 'SQL Server' was included in the error text, the error was not then passed back to the user/logs. This change ensure that errors returned are passed back properly by inspecting the Errors property of the ADO object used to run the query. Note that this may not behave as expected if the error that occurrs is of sufficently low severity that a rowset, even if empty, is also returned. If a rowset is returned by the ADO object, the object will not populate the Errors property, and there is no way to tell a low severity error occurred. For instance 'Select 1/0' returns a low severity division by zero error, and an empty rowset. Because the empty rowset exists, the error cannot be seen. It is up to the user to ensure that the errors they want to catch are of sufficienty severity that execution of the query is halted.
Merge pull request #263 from RandomNoun7/tickets/main/MODULES-6281-mo…
…dule_does_not_return_errors (MODULES-6281) Return Errors from T-SQL
(MODULES-6760) Release prep SQL 2.1.1
(MODULES-6760) prep for 2.1.1 release
Merge pull request #265 from RandomNoun7/tickets/release/MODULES-6760…
…-release-prep-2.1.1 (MODULES-6760) prep for 2.1.1 release
This commit fixes the markdown link to MODULES-6339 explaining why the command to update bundle was removed from TRAVISCI builds.
Merge pull request #266 from RandomNoun7/maint/release/fix_changelog_…
…error (MAINT) Fix Changelog Link
Merge pull request #267 from RandomNoun7/maint/release/fix_release_da…
…te_in_changelog (MAINT) Fix Release Date in Changelog