(MODULES-8761) Mergeback from 2.5.0 Release

(MAINT) add support for 2019 to test helpers

(MODULES-6582) Add ability to test against sql server 2017

A user trying to follow our advanced example ran into an issue. The
example as written is only suitable for setups that are using local
accounts, not domain accounts. They also found that the Facter fact
`domain` returns the FQDN of the domain, which is not suitable for
contsructing user names in the `netbiosname\username` format.

This change adds a clarification to the example that the example is only
usable when using local group, and given that there is no `netbiosname`
fact available, provides a suggestion for one way to work around the
issue.

(MODULES-7553) Add Example Clarification

(MODULES-8600) add DQC to sqlserver_features

  Prior to this commit, when a registry key in HKEY_LOCAL_MACHINE\Software\Microsoft\Microsoft SQL Server\Instance Names was missing the key about the current version the custom fact sqlserver_instances would throw an error message similar to this: 2019-01-06 14:55:09 -0500 Facter (err): error while resolving custom fact "sqlserver_instances": Failed to open registry key 'HKEY_LOCAL_MACHINE\Software\Microsoft\Microsoft SQL Server\MSRS11.@SharePoint\MSSQLServer\CurrentVersion': The system cannot find the file specified.

  This commit adds a check before trying to open the version information registry key.

(MODULES-8439) Fix sqlserver_instances custom fact

Prviously, the sp_configure.pp file would attempt to use the builtin
service resource to restart the MSSQLServer service if a configuration
change was made. This attempt would fail if there was a dependent
service such as the SQL Agent service, which is extremely common.

This change implements an extremely small PowerShell script instead to
force restart the MSSQLSERVER service, even if there are dependent
services.

In testing this resulted in the Agent service going down and then
coming back up as expected.

…-service

(MODULES-6904) Restart SQL Server Service with Dependent Services

The issues link points at an area in Jira that no longer exists. This
change fixes it to point at a more generic place that will allow users
to createa a ticket.

…ues-link

(MODULES-9472) Fix Issues Link

…e and process

This commit adds the following alignement elements:
- Remove Puppet 4 support
- Run pdk update
- Fully enable rubocop
- Add Puppet Strings

MODULES-9383 - Align windows module SQLServer to core modules

Prior to this change, some ERB templates would cause jruby errors
on the master during catalog compilation. The templates contained code
that would attempt to modify the value of a frozen string.

This change modifies the template code to ensure that no frozen string
values are attempted to be modified.

It also makes slight fixes to the syntax in the templates to ensure that
each instance of this pattern is written more consistantly.

…plate-frozen-string-error

(MODULES-9912) ERB Template Errors

(maint) Add a codeowners file

(MODULES-9918) ReleasePrep v2.5.1