From d3440081567c61bc12b372074bacc853c136930e Mon Sep 17 00:00:00 2001 From: Glenn Sarti Date: Tue, 13 Jun 2017 14:21:09 -0700 Subject: [PATCH] (MODULES-5030) Remove service_ensure parameter Previously the service_ensure parameter was defined in the type however it was never implemented in the provider. As such this param had no effect. This commit removes the parameter because: - This parameter is confusing as it is only applicable at installation time, not constantly enforced - Each service can have a different startup type. This is already possible using the install_switches e.g. /BROWSERSVCSTARTUPTYPE=Disabled - Ongoing Windows service state should really be managed by a puppet manifest not by an installation switch --- README.md | 4 ---- lib/puppet/type/sqlserver_instance.rb | 5 ----- 2 files changed, 9 deletions(-) diff --git a/README.md b/README.md index ebabe8ad..2a7c8769 100644 --- a/README.md +++ b/README.md @@ -340,10 +340,6 @@ Specifies a security mode for SQL Server. Valid options: 'SQL'. If not specified Default: `undef`. -##### `service_ensure` - -Specifies whether the SQL Server service should be running. Valid options: 'automatic' (Puppet starts the service if it's not running), 'manual' (Puppet takes no action), and 'disable' (Puppet stops the service if it's running). - ##### `source` *Required.* diff --git a/lib/puppet/type/sqlserver_instance.rb b/lib/puppet/type/sqlserver_instance.rb index 026316f2..13e1d62c 100644 --- a/lib/puppet/type/sqlserver_instance.rb +++ b/lib/puppet/type/sqlserver_instance.rb @@ -44,11 +44,6 @@ end - newparam(:service_ensure) do - desc 'Automatic will ensure running if stopped, Manual will set to manual and take no action on current state, :diable will stop and change to service disabled' - newvalues(:automatic, :manual, :disable) - end - newparam(:sql_svc_account, :parent => Puppet::Property::SqlserverLogin) do desc 'Account for SQL Server service: Domain\User or system account.' # Default to "NT Service\SQLAGENT$#{instance_name}"