Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh_authorized_key: Fix invalid 'options' error #10

Merged
merged 1 commit into from
Oct 31, 2018
Merged

ssh_authorized_key: Fix invalid 'options' error #10

merged 1 commit into from
Oct 31, 2018

Conversation

natemccurdy
Copy link
Contributor

Prior to this, the example of a valid "options" value for the ssh_authorized_key type was syntactically incorrect; it did not include the closing single quote.

Example of incorrect error message:

Error: Parameter options failed on Ssh_authorized_key[testkey]: Option from=foo.com is not valid. A single option must either be of the form 'option' or 'option="value". Multiple options must be provided as an array (file: /tmp/test.pp, line: 5)

After this, the error shows the correct syntax for specifying an option:

Error: Parameter options failed on Ssh_authorized_key[testkey]: Option from=foo.com is not valid. A single option must either be of the form 'option' or 'option="value"'. Multiple options must be provided as an array (file: /tmp/test.pp, line: 5)

Prior to this, the example of a valid "options" value for the
ssh_authorized_key type was syntactically incorrect; it did not include
the closing single quote.

Example of incorrect error message:

```
Error: Parameter options failed on Ssh_authorized_key[testkey]: Option from=foo.com is not valid. A single option must either be of the form 'option' or 'option="value". Multiple options must be provided as an array (file: /tmp/test.pp, line: 5)
```

After this, the error shows the correct syntax for specifying an option:

```
Error: Parameter options failed on Ssh_authorized_key[testkey]: Option from=foo.com is not valid. A single option must either be of the form 'option' or 'option="value"'. Multiple options must be provided as an array (file: /tmp/test.pp, line: 5)
```
Copy link
Contributor

@reidmv reidmv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch. Looks good to me! 👍

@reidmv reidmv merged commit 1a70da8 into puppetlabs:master Oct 31, 2018
@natemccurdy natemccurdy deleted the nmccurdy/fix_options_doc branch October 31, 2018 16:57
@GabrielNagy GabrielNagy added the bug Something isn't working label Oct 24, 2019
@GabrielNagy GabrielNagy changed the title ssh_authorzed_key: Fix invalid 'options' error ssh_authorized_key: Fix invalid 'options' error Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants