Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-10765) Implement public key certificate support #35

Merged
merged 6 commits into from
Sep 7, 2020
Merged

(MODULES-10765) Implement public key certificate support #35

merged 6 commits into from
Sep 7, 2020

Conversation

bastelfreak
Copy link
Contributor

No description provided.

@puppet-community-rangefinder
Copy link

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 5 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak bastelfreak force-pushed the MODULES-10765 branch 3 times, most recently from c28bda1 to ec8706e Compare August 6, 2020 19:36
@bastelfreak bastelfreak changed the title (MODULES-10765) Implement ssh-rsa-cert-v01@openssh.com support (MODULES-10765) Implement public key certificate support Aug 6, 2020
@bastelfreak
Copy link
Contributor Author

I went ahead and implemented all types from https://raw.githubusercontent.com/openssh/openssh-portable/master/PROTOCOL.certkeys

@bastelfreak bastelfreak closed this Aug 6, 2020
@bastelfreak bastelfreak reopened this Aug 6, 2020
@puppet-community-rangefinder
Copy link

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 5 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@bastelfreak
Copy link
Contributor Author

I tested this also in my own environment and can verify that this doesn't break anymore if such keys are present on the system.

@bastelfreak
Copy link
Contributor Author

ping :)

@ciprianbadescu ciprianbadescu reopened this Sep 4, 2020
@puppet-community-rangefinder
Copy link

ssh_authorized_key is a type

Breaking changes to this file MAY impact these 88 modules (near match):

This module is declared in 5 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@ciprianbadescu ciprianbadescu changed the base branch from master to main September 4, 2020 06:50
@ciprianbadescu ciprianbadescu requested a review from a team September 4, 2020 06:50
@bastelfreak
Copy link
Contributor Author

Hi people. I notice that there are no code owners defined here. Is this on purpose or was that missed? I thought all maintained Puppet repos now have that.

@GabrielNagy
Copy link
Contributor

There is a codeowners file https://github.com/puppetlabs/puppetlabs-sshkeys_core/blob/main/CODEOWNERS so a review request should have been triggered, I'm not sure why it didn't happen.

@GabrielNagy
Copy link
Contributor

PR looks good 👍, thanks for the contribution!

@GabrielNagy GabrielNagy merged commit bd8183b into puppetlabs:main Sep 7, 2020
@bastelfreak bastelfreak deleted the MODULES-10765 branch October 16, 2020 12:16
@bastelfreak
Copy link
Contributor Author

@GabrielNagy could you kick off a new release soonish?

@GabrielNagy
Copy link
Contributor

sure @bastelfreak, as it happens we already have the release ticket in our sprint 😄 gonna jump on it

@GabrielNagy GabrielNagy added the feature New feature or request label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielNagy GabrielNagy GabrielNagy approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @GabrielNagy @ciprianbadescu