-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the password parameter optional #65
Conversation
Not all environments will require a password on a certificate
|
Fixes #64 |
|
I can only guarantee that this allows the user to skip providing the password. Someone who uses the module will have to try it to ensure the two powershell scripts work properly when provided with a password of |
|
@rnelson0 Thanks for making this! Quick clarification, your patch will allow a password of either a String[1] or undef, not the empty string. But that should be fine.... assuming the PowerShell scripts can handle that (a quick look makes me think they can). With your patch, this should be possible now (note the lack of a password): sslcertificate { "Install-PFX-Certificate" :
name => 'mycert.pfx',
location => 'C:\',
thumbprint => '07E5C1AF7F5223CB975CC29B5455642F5570798B'
}But this will still throw an error (which is fine if the above works): sslcertificate { "Install-PFX-Certificate" :
name => 'mycert.pfx',
password => '',
location => 'C:\',
thumbprint => '07E5C1AF7F5223CB975CC29B5455642F5570798B'
} |
|
@natemccurdy I was referring to the underlying powershell script's cmdlet receiving |
No description provided.