Don't store the PS1 scripts #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnelson0
suggested changes
Jan 29, 2018
Prior to this, the module creates the set and check scripts as files on disk. This meant that the passwords and script information would be left hanging around. This fixes that by building the check and set scripts only when running the exec. The exec's "command" and "onlyif" parameters now build the templates directly rather than use the scripts on disk. I've left the "scripts_dir" parameter around for backwards compatibility. It doesn't do anything, but leaving it around means that people's existing code won't break. In a X release of this module, that deprecated parameter should be removed.
|
@rnelson0 Rubocop fixes are in and passing. |
juniorsysadmin
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, the module creates the set and check scripts as files on
disk. This meant that the passwords and script information would be left
hanging around.
This fixes that by building the check and set scripts only when running
the exec. The exec's "command" and "onlyif" parameters now build the
templates directly rather than use the scripts on disk.
I've left the "scripts_dir" parameter around for backward
compatibility. It doesn't do anything, but leaving it around means that
people's existing code won't break.
In a X release of this module, that deprecated parameter should be
removed.
Before merging this, someone should check that the sslcertificate type actually works. There are no acceptance tests, so manual verification is needed.