Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.3
Choose a base ref
...
head repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.4
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on May 26, 2011

  1. Move stages to after main 

    Working with the stages in stdlib, I quickly ran into an issue where
most of the stages were before the main stage.  This made it difficult
to declare any resources in a traditional "include" style class while
hiding the end user from the stages being associated with other module
classes.

For example, in class mcollective, a package would be declared in main.
However, if mcollective declared class mcollective::service in stage
infra_deploy and this was before main, there would be a dependency loop
between the package and the service.

There appears to be a convention around "chain your stages after main"
to avoid the need to create relatively empty shell classes.
    Jeff McCune committed May 26, 2011
    Configuration menu
    Copy the full SHA
    6e9e838 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bug/master/prefer_stages_after_main' 

    * bug/master/prefer_stages_after_main:
  Move stages to after main
    Jeff McCune committed May 26, 2011
    Configuration menu
    Copy the full SHA
    7eaceba View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG with stage re-ordering

    Jeff McCune committed May 26, 2011
    Configuration menu
    Copy the full SHA
    cdbdc27 View commit details
    Browse the repository at this point in the history
Loading