Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.20.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.21.0
Choose a head ref
  • 19 commits
  • 16 files changed
  • 14 contributors

Commits on Jul 11, 2017

  1. Fix filenames of two function spec tests

    The tests weren't being run.  Total tests increase from 2742 to 2769.
    
    Also fix 'when using a class extending String' test.
    It had been failing with...
    ```
    RuntimeError:
           can't modify frozen AlsoString
    ```
    alexjfisher committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    2220810 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. Merge pull request #815 from puppetlabs/release

    version 4.20.0 mergeback
    HAIL9000 authored Sep 12, 2017
    Configuration menu
    Copy the full SHA
    e041157 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2017

  1. (maint) modulesync 892c4cf

    HAIL9000 committed Sep 18, 2017
    Configuration menu
    Copy the full SHA
    81ab03e View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. Allow root as valid UNIX path

    Since the purpose of this validation type is to check if the given parameter is a valid UNIX path it should also cover the root path "slash" since it might be possible that it is specified as a target directory.
    kofrezo committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    51c9dc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2017

  1. fix quoting style in validate_legacy example (#816)

    I used the example code from this README file but i got downvotes from CI / jenkins / puppet-lint because it doesn't conform to Puppet style guides to use double quotes here. It produces "double quoted string containing no variables" warnings.
    
    I wanted to fix the example locally but it was pointed out to me we should fix it upstream stdlib instead.
    mutante authored and tphoney committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    e66f7aa View commit details
    Browse the repository at this point in the history
  2. Merge pull request #777 from alexjfisher/fix_test_filenames

    Fix filenames of two function spec tests
    tphoney authored Sep 25, 2017
    Configuration menu
    Copy the full SHA
    ff63455 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #817 from puppetlabs/msync_18sep17_892c4cf

    (maint) modulesync 892c4cf
    tphoney authored Sep 25, 2017
    Configuration menu
    Copy the full SHA
    ee9d08a View commit details
    Browse the repository at this point in the history
  4. removing duplicate test absolute_path test

    tphoney committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    d698569 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #818 from tphoney/remove_defunct_test

    removing duplicate test absolute_path test
    pmcmaw authored Sep 25, 2017
    Configuration menu
    Copy the full SHA
    1ff9956 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. Merge pull request #811 from kofrezo/master

    Allow root as valid UNIX path
    pmcmaw authored Sep 26, 2017
    Configuration menu
    Copy the full SHA
    2b2b387 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2017

  1. (maint) Clarify docs and add new tests

    Based on a Stack Overflow question, it was noted that the documentation
    for `file_line` isn't complete and the underlying behaviour somewhat
    confusing.
    
    https://stackoverflow.com/questions/46468922/how-to-change-the-contents-of-a-file-by-using-puppet/46473458
    
    In this patch I add additional unit tests and better examples and
    complete documentation.
    alex-harvey-z3q committed Sep 29, 2017
    Configuration menu
    Copy the full SHA
    ad5d924 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2017

  1. Merge pull request #820 from alexharv074/maint_clarify_docs

    (maint) Clarify docs and add new tests
    tphoney authored Oct 2, 2017
    Configuration menu
    Copy the full SHA
    2339ea8 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2017

  1. (MODULES-5651) Do not append infinitely

    https://tickets.puppetlabs.com/browse/MODULES-5003 gave rise to
    #788 and
    #794 which caused
    different behavior based on whether the line value was matched by the
    match regex or not.
    
    The change in behavior was both breaking and broken, though that was
    hard to tell because the behavior was ill-described in general.
    
    [bugfix] This commit resolves the breaking behavior by reverting the
    behavior of "replacing matches when a line matching `line` exists even
    when `multiple` is set to `true`".
    
    [feature] This commit adds a new parameter to make file_line replace all
    matches universally with the `line` value, even when the line exists
    elsewhere in the file. This feature only affects modifying multiple
    lines in a file when the `line` value already exists.
    
    [bugfix] This commit more strictly defines the various interactions of
    `ensure`, `match`, `append_on_no_match`, `replace`, `multiple`, and
    `replace_all_matches_not_matching_line`. It also more clearly documents
    and tests these interactions.
    hunner committed Oct 16, 2017
    Configuration menu
    Copy the full SHA
    54ffdd8 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2017

  1. Merge pull request #825 from hunner/fix_append

    (MODULES-5651) Do not append infinitely
    HAIL9000 authored Oct 17, 2017
    Configuration menu
    Copy the full SHA
    8376c9b View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2017

  1. Configuration menu
    Copy the full SHA
    0f67df2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #827 from eputnam/release4210

    (MODULES-5806) release prep for version 4.21.0
    HAIL9000 authored Oct 25, 2017
    Configuration menu
    Copy the full SHA
    38d571b View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. README fixups for 4.21.0 release

    jbondpdx committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    8733960 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #828 from jbondpdx/release

    README fixups for 4.21.0 release
    david22swan authored Oct 26, 2017
    Configuration menu
    Copy the full SHA
    77327c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2017

  1. Configuration menu
    Copy the full SHA
    5d6cca1 View commit details
    Browse the repository at this point in the history
Loading