-
Notifications
You must be signed in to change notification settings - Fork 581
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-stdlib
base: v9.1.0
head repository: puppetlabs/puppetlabs-stdlib
compare: v9.2.0
- 10 commits
- 26 files changed
- 6 contributors
Commits on Jun 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 108a699 - Browse repository at this point
Copy the full SHA 108a699View commit details -
Merge pull request #1372 from puppetlabs/CONT-990-Pull_Requests_template
pdksync - (CONT-990) - Adding Community Pull Requests template
Configuration menu - View commit details
-
Copy full SHA for 44b6065 - Browse repository at this point
Copy the full SHA 44b6065View commit details -
Pass calling scope to
stdlib::ensure_packagesfrom shimMake the `ensure_packages` shim an Internal function and pass scope to the namespaced version so as to not change the behaviour of where packages are contained. When the function was first ported to the new API, it was discussed that the existing behaviour might not be 'correct', but changing it would be a breaking change that might have consequences for many users. In namespacing the function in 9.0.0 we accidentally created a situation where the namespaced version worked as before, but the non-namespaced version, (the shim), now behaved differently. Fixes #1374
Configuration menu - View commit details
-
Copy full SHA for a68c958 - Browse repository at this point
Copy the full SHA a68c958View commit details -
Merge pull request #1366 from alexjfisher/issue1365
Pass calling scope to `stdlib::ensure_packages` from shim
Configuration menu - View commit details
-
Copy full SHA for 3df8f0c - Browse repository at this point
Copy the full SHA 3df8f0cView commit details
Commits on Jun 27, 2023
-
Add
use_strict_settingparameter todeprecationfunctionIn this change, an optional third parameter is added to the `deprecation` function. The default behaviour remains the same, but when the third parameter is set to `false`, Puppet's `strict` setting is ignored. This means that even if `strict` is set to `error`, no exception will be raised when this function is called, and a warning will be logged instead. This is a prerequisite for #1373
Configuration menu - View commit details
-
Copy full SHA for f7dd14a - Browse repository at this point
Copy the full SHA f7dd14aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b64d06 - Browse repository at this point
Copy the full SHA 4b64d06View commit details -
Ignore Puppet's
strictsetting when calling function without namespacePreviously, when a user had the Puppet setting `strict` set to `error` (which is the default in Puppet 8), a call to one of stdlib's functions via the deprecated non-namespaced function would cause a hard failure instead of just logging a warning and calling the real namespaced function. In this change, all of our shims have been updated to call `deprecation` with its new third parameter, (`use_strict_setting`), set to `false`. The non-namespaced versions will now only ever log warnings informing users to moved to the namespaced versions. It will not raise exceptions even if `strict` is set to `error`. This change will make it much easier for users to migrate to stdlib 9 (and to upgrade modules that now depend on stdlib 9) Fixes #1373
Configuration menu - View commit details
-
Copy full SHA for 2760ee6 - Browse repository at this point
Copy the full SHA 2760ee6View commit details -
Merge pull request #1377 from alexjfisher/issue_1373
Ignore Puppet's `strict` setting when calling function without namespace
Configuration menu - View commit details
-
Copy full SHA for 904b395 - Browse repository at this point
Copy the full SHA 904b395View commit details -
GitHub Actions committed
Jun 27, 2023 Configuration menu - View commit details
-
Copy full SHA for d264ee9 - Browse repository at this point
Copy the full SHA d264ee9View commit details -
Merge pull request #1380 from puppetlabs/release-prep
Release prep v9.2.0
Configuration menu - View commit details
-
Copy full SHA for 49cc0e0 - Browse repository at this point
Copy the full SHA 49cc0e0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v9.1.0...v9.2.0