Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-stdlib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.2.0
Choose a head ref
  • 10 commits
  • 26 files changed
  • 6 contributors

Commits on Jun 15, 2023

  1. Configuration menu
    Copy the full SHA
    108a699 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1372 from puppetlabs/CONT-990-Pull_Requests_template

    pdksync - (CONT-990) - Adding Community Pull Requests template
    jordanbreen28 authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    44b6065 View commit details
    Browse the repository at this point in the history
  3. Pass calling scope to stdlib::ensure_packages from shim

    Make the `ensure_packages` shim an Internal function and pass scope to
    the namespaced version so as to not change the behaviour of where
    packages are contained.
    
    When the function was first ported to the new API, it was discussed that
    the existing behaviour might not be 'correct', but changing it would be
    a breaking change that might have consequences for many users.
    
    In namespacing the function in 9.0.0 we accidentally created a situation
    where the namespaced version worked as before, but the non-namespaced
    version, (the shim), now behaved differently.
    
    Fixes #1374
    alexjfisher committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    a68c958 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1366 from alexjfisher/issue1365

    Pass calling scope to `stdlib::ensure_packages` from shim
    jordanbreen28 authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    3df8f0c View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Add use_strict_setting parameter to deprecation function

    In this change, an optional third parameter is added to the
    `deprecation` function.  The default behaviour remains the same, but
    when the third parameter is set to `false`, Puppet's `strict` setting is
    ignored. This means that even if `strict` is set to `error`, no
    exception will be raised when this function is called, and a warning
    will be logged instead.
    
    This is a prerequisite for #1373
    alexjfisher committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    f7dd14a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b64d06 View commit details
    Browse the repository at this point in the history
  3. Ignore Puppet's strict setting when calling function without namespace

    Previously, when a user had the Puppet setting `strict` set to `error` (which
    is the default in Puppet 8), a call to one of stdlib's functions via the
    deprecated non-namespaced function would cause a hard failure instead of just
    logging a warning and calling the real namespaced function.
    
    In this change, all of our shims have been updated to call `deprecation` with
    its new third parameter, (`use_strict_setting`), set to `false`. The
    non-namespaced versions will now only ever log warnings informing users to
    moved to the namespaced versions. It will not raise exceptions even if `strict`
    is set to `error`.
    
    This change will make it much easier for users to migrate to stdlib 9 (and to
    upgrade modules that now depend on stdlib 9)
    
    Fixes #1373
    alexjfisher committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    2760ee6 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1377 from alexjfisher/issue_1373

    Ignore Puppet's `strict` setting when calling function without namespace
    chelnak authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    904b395 View commit details
    Browse the repository at this point in the history
  5. Release prep v9.2.0

    GitHub Actions committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d264ee9 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #1380 from puppetlabs/release-prep

    Release prep v9.2.0
    LukasAud authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    49cc0e0 View commit details
    Browse the repository at this point in the history
Loading