-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a stdlib::ip_in_range() function #1003
Conversation
|
I think this needs to be refactored to use the modern (4.x) function API, and that the function should be namespaced to Others need to chime in on the usefulness of the function and if it should be added to stdlib in the first place. I will make some review comments meanwhile. |
|
This documentation may be of value: https://puppet.com/docs/puppet/6.3/functions_refactor_legacy.html |
|
Hey, @hlindberg ! Thank u, for ur revision, i appreciate it! I've done some fixes. Could u plz check it and says what should i doing next? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! I added a couple of suggestions with improvements to the documentation of the parameters.
Once you changed this, do squash all your commits into one and write the commit comment in imperative form (suggestion): Add a stdlib::ip_in_range() function to check if a given IP is in a given range
|
Hey, @hlindberg ! Thanks a lot, ur so helpful! Now, how i think, i totally done with this task :) |
|
Hi @iglov . Thanks for your contribution (and @hlindberg for reviewing). This change looks good to me. Cheers! |
It's very useful function from https://github.com/deanwilson/puppet-ip_in_range . Why you haven't include it so far?