Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Stdlib::Syslogfacility type #1005

Merged
merged 1 commit into from
Sep 18, 2019
Merged

add Stdlib::Syslogfacility type #1005

merged 1 commit into from
Sep 18, 2019

Conversation

bastelfreak
Copy link
Collaborator

No description provided.

This was referenced Mar 9, 2019
Merged
Open
bastelfreak added a commit to bastelfreak/puppet-nrpe that referenced this pull request Mar 9, 2019
@bastelfreak
Nrpe::Syslogfacility -> Stdlib::Syslogfacility
d285603 
The syslogfacility type is present in stdlib, so we should use it.
Before merging this,
puppetlabs/puppetlabs-stdlib#1005 needs to be
released. We also need to update metadata.json
@bastelfreak bastelfreak mentioned this pull request Mar 9, 2019
Open
@sheenaajay
Copy link
Contributor

Hi @bastelfreak ,Hasn't seen any activity in this PR, do you think you'll be able to work on it in the near future? No pressure, just checking in.

@alexjfisher
Copy link
Collaborator

@sheenaajay Is there any extra work required? I don't think my nitpick should be a blocker.

@sheenaajay
Copy link
Contributor

Thank you @alexjfisher .
Hi @bastelfreak , Could you please resolve the conflicts and rebase with the latest master to run the acceptance tests.Thank you.

@bastelfreak
Copy link
Collaborator Author

@sheenaajay I rebased it

@sheenaajay
Copy link
Contributor

Screen Shot 2019-09-18 at 09 26 16

@sheenaajay
Copy link
Contributor

Thank you for submitting the PR @bastelfreak.

@sheenaajay
Copy link
Contributor

Great work...

@sheenaajay sheenaajay merged commit 645b826 into puppetlabs:master Sep 18, 2019
@bastelfreak bastelfreak deleted the facility branch September 19, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjfisher alexjfisher alexjfisher left review comments

@iglov iglov iglov approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bastelfreak @sheenaajay @alexjfisher @iglov