Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9915) Add type aliases for cloud object store uris #1048

Merged
merged 1 commit into from
Sep 17, 2019
Merged

(MODULES-9915) Add type aliases for cloud object store uris #1048

merged 1 commit into from
Sep 17, 2019

Conversation

hooten
Copy link
Contributor

@hooten hooten commented Sep 16, 2019

Closes https://tickets.puppetlabs.com/browse/MODULES-9915

Add a type alias for Cloud Object Store URIs, e.g., (s3://mybucket/myfile).

These URIs are commonly used as sources for files, packages, etc. in Puppet modules. Some organizations even keep all sources in a specific cloud object store like s3 in order to limit downloads from the internet when applying a Puppet catalogue across potentially thousands of nodes.

It would be useful to have a type alias for these URIs.

@hooten
Copy link
Contributor Author

hooten commented Sep 16, 2019

I'd appreciate a review when you get a chance @lionce or @tphoney. Thanks!

@tphoney
Copy link
Contributor

tphoney commented Sep 17, 2019

Great work, a nice addition.

@tphoney tphoney merged commit 3246d92 into puppetlabs:master Sep 17, 2019
@hooten
Copy link
Contributor Author

hooten commented Sep 17, 2019

Thanks!

@hooten hooten deleted the modules9915 branch September 17, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants