Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAC-547] Remove strftime from stdlib as it has already been replaced by the puppet agent since 4.8.0 #1097

Merged
merged 2 commits into from
Mar 9, 2020

Conversation

carabasdaniel
Copy link
Contributor

@carabasdaniel carabasdaniel requested a review from a team as a code owner March 9, 2020 09:56
@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #1097 into master will increase coverage by 0.96%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1097      +/-   ##
=========================================
+ Coverage    3.74%   4.71%   +0.96%     
=========================================
  Files         186     185       -1     
  Lines        5338    5258      -80     
=========================================
+ Hits          200     248      +48     
+ Misses       5138    5010     -128
Impacted Files Coverage Δ
lib/puppet/type/file_line.rb 96.36% <0%> (+1.81%) ⬆️
lib/puppet/provider/file_line/ruby.rb 62.62% <0%> (+47.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa2fee...c1f8dd7. Read the comment docs.

@michaeltlombardi
Copy link
Contributor

Marking this as a maintenance commit as the function is already overridden by the function within Puppet, meaning this is not a backwards breaking change.

@michaeltlombardi michaeltlombardi merged commit aee40f8 into puppetlabs:master Mar 9, 2020
@DavidS DavidS changed the title [IAC-547] Remove strftime from stdlib [IAC-547] Remove strftime from stdlib as it has already been replaced by the puppet agent since 4.8.0 Mar 10, 2020
@DavidS DavidS added bugfix and removed maintenance labels Mar 10, 2020
@DavidS
Copy link
Contributor

DavidS commented Mar 10, 2020

Relabelled and retitled as bugfix so it shows up on the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants