Stdlib::Datasize: This CR adds a new data size type alias #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manay class/define paramters take a value representing a data size. e.g. 1024Mb, 1024G, 100k This new type provides a way to validate most common data type inputs
Codecov Report
@@ Coverage Diff @@
## main #1126 +/- ##
=====================================
Coverage 5.31% 5.31%
=====================================
Files 185 185
Lines 5273 5272 -1
=====================================
Hits 280 280
+ Misses 4993 4992 -1
Continue to review full report at Codecov.
|
|
Hi @b4ldr, the PR looks good! Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many class/define parameters take a value representing a data size.
e.g. 1024Mb, 1024G, 100k
This new type provides a way to validate most common data type inputs