Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsehocon() function #1130

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Add parsehocon() function #1130

merged 1 commit into from
Sep 28, 2020

Conversation

reidmv
Copy link
Contributor

@reidmv reidmv commented Sep 26, 2020

This function aligns with the existing parsejson and parseyaml functions, providing similar functionality for HOCON strings. This is useful for dealing with Puppet configuration files, many of which are HOCON format.

This function aligns with the existing parsejson and parseyaml
functions, providing similar functionality for HOCON strings. This is
useful for dealing with Puppet configuration files, many of which
are HOCON format.
@reidmv reidmv requested a review from a team as a code owner September 26, 2020 20:53
@puppet-community-rangefinder
Copy link

parsehocon is a function

that may have no external impact to Forge modules.

This module is declared in 318 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2020

Codecov Report

Merging #1130 into main will increase coverage by 0.89%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main   #1130      +/-   ##
========================================
+ Coverage   4.40%   5.29%   +0.89%     
========================================
  Files        185     186       +1     
  Lines       5272    5289      +17     
========================================
+ Hits         232     280      +48     
+ Misses      5040    5009      -31     
Impacted Files Coverage Δ
lib/puppet/functions/parsehocon.rb 0.00% <0.00%> (ø)
lib/puppet/type/file_line.rb 96.36% <0.00%> (+1.81%) ⬆️
lib/puppet/provider/file_line/ruby.rb 62.62% <0.00%> (+47.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8cdc6...11b1048. Read the comment docs.

Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement @reidmv !

@sanfrancrisko sanfrancrisko merged commit da816a7 into puppetlabs:main Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants