Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-11099) Make merge parameter data types actually backwards compatible #1191

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

LadyNamedLaura
Copy link
Contributor

Hash defaults to Hash[Scalar,Data] however, class/type references are valid hash values but are not covered by the Data type.

see also voxpupuli/puppet-jenkins#909

@LadyNamedLaura LadyNamedLaura requested a review from a team as a code owner June 7, 2021 11:28
@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

merge is a function

Breaking changes to this file MAY impact these 301 modules (near match):

This module is declared in 318 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@LadyNamedLaura LadyNamedLaura force-pushed the patch-3 branch 2 times, most recently from c9c29db to b0e367a Compare June 8, 2021 12:08
@LadyNamedLaura LadyNamedLaura changed the title Make merge parameter data types actually backwards compatible (MODULES-11099) Make merge parameter data types actually backwards compatible Jun 8, 2021
`Hash` defaults to `Hash[Scalar,Data]` however, class/type references are valid hash values but are not covered by the `Data` type.

see also voxpupuli/puppet-jenkins#909
@b4ldr b4ldr merged commit b4048fd into puppetlabs:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants