Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify stdlib::manage #1250

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Simplify stdlib::manage #1250

merged 2 commits into from
Jul 11, 2022

Conversation

jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Jun 6, 2022

This should make the resources much less sensitive to parse order,
since pupppet is already "doing the right thing" to Strings in this
parameter location.

This should make the resources much less sensitive to parse order,
since pupppet is already "doing the right thing" to Strings in this
parameter location.
@jcpunk jcpunk requested a review from a team as a code owner June 6, 2022 15:01
@puppet-community-rangefinder
Copy link

stdlib::manage is a class

that may have no external impact to Forge modules.

This module is declared in 318 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

petergmurphy
petergmurphy previously approved these changes Jun 20, 2022
spec/classes/manage_spec.rb Outdated Show resolved Hide resolved
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise 👍 but I'm not sure what's up with the acceptance tests, but I also saw it in a different puppetlabs repo. Infrastructure issue?

@jcpunk jcpunk requested a review from petergmurphy June 20, 2022 15:22
@chelnak chelnak merged commit 7f07bdf into puppetlabs:main Jul 11, 2022
@jcpunk jcpunk deleted the simplify-manage branch July 11, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants