-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Stdlib::CreateResources type #1267
Conversation
|
@ekohl This look's good to me. |
|
I'm a fan of types being singular nouns. I wonder if calling this type 'resource' would be too ambiguous? |
It is very common to have a parameter which creates resources, either via `create_resources()` or via iteration.
48068b4
to
e8ba623
Compare
This describes multiple resources. You can't get away from it IMHO. For example, you also have ensure_resource and ensure_resources. If you were to define types for that, you'd also have one singular and one plural. Technically you have this: type Stdlib::ResourceAttribute = Any
type Stdlib::ResourceAttributes = Hash[String[1], Stdlib::ResourceAttribute]
type Stdlib::CreateResources = Hash[String[1], Stdlib::ResourceAttributes]But that's really verbose. Also, you could also narrow down the title to a |
|
Yeah fair enough. I can see your point here. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thank's for getting the rebase done so fast :) |
It is very common to have a parameter which creates resources, either via
create_resources()or via iteration.