[#20862] Add functions to validate ipv4 and ipv6 addresses #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update some of the examples; pre 3xx patch levels of 1.9.3 seem to allow invalid IPv6 addresses to be passed in. |
|
1.8.7 also seems to be confused about IPv6 in general. |
| end | ||
| end | ||
|
|
||
| # 1.8.7 is EOL'd and also absolutely insane about ipv6 |
There was a problem hiding this comment.
What's the behavior of ruby 1.8.7 and ipv6? Do we need to add a note about this in the method documentation?
|
@wfarr I still don't fully understand the behavior of this code on Ruby 1.8.7 (#158 (comment)), would you be able to update this pull request this week with that information? |
adrienthebo
added a commit
that referenced
this pull request
Jun 7, 2013
[#20862] Add functions to validate ipv4 and ipv6 addresses
|
summary: merged into master in ca7633c. I would still like to know what's the story behind #158 (comment) but I would rather get this in now than wait any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plenty of software out there still supports IPv4 only, and it’s helpful to make sure that the bind addresses given to modules are of a certain class of IP.