(PUP-1459) Add support for root_home on OS X 10.9 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to add a spec test but I got stuck on how to enable fixtures. Is there an easy way to do that? Looks like core facter has it's own functions in facter/spec/puppetlabs_spec to handle it. |
|
@blkperl the output of that command is short enough that I think you can just include it inline in the test. |
|
@zaphod42 Tests added, figured out fixtures too |
getent does not exist on 10.9 so this commit uses dscacheutil to query the homedir for the root user.
zaphod42
added a commit
that referenced
this pull request
Jan 28, 2014
(PUP-1459) Add support for root_home on OS X 10.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getent does not exist on 10.9 so this commit uses
dscacheutil to query the homedir for the root user.