MODULES-467 Function file_join for smart path joining #223

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
@ASCIIDuck

No description provided.

Kristopher Kirkland added some commits Feb 26, 2014

Kristopher Kirkland
Changed the input parameters to be more flexible.
I realized keeping basically the same input parameters as join()
was a little silly. It will now take any mess of nested arrays of
strings.
@apenney

This comment has been minimized.

Show comment Hide comment
@apenney

apenney Mar 11, 2014

Contributor

Hi,

Part of the mandate for stdlib is "functions that will be useful to almost all users of stdlib". I feel like, while this is a cool feature (and I could see myself using it) it's a little too specific and obscure for most people.

I think this would belong better in another module given the infrequent use cases for it, and as such I'm going to close this PR. Please don't take this to mean it's not a useful puppet function, however, I'm just unsure it belongs in stdlib!

Contributor

apenney commented Mar 11, 2014

Hi,

Part of the mandate for stdlib is "functions that will be useful to almost all users of stdlib". I feel like, while this is a cool feature (and I could see myself using it) it's a little too specific and obscure for most people.

I think this would belong better in another module given the infrequent use cases for it, and as such I'm going to close this PR. Please don't take this to mean it's not a useful puppet function, however, I'm just unsure it belongs in stdlib!

@apenney apenney closed this Mar 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment