Need to convert strings and fixnums to arrays #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ module Puppet::Parser::Functions | |||
| raise(Puppet::ParseError, 'member(): Requires array to work with') | |||
| end | |||
|
|
|||
| if arguments[1].is_a? String | |||
| if arguments[1].is_a? String or arguments[1].is_a? Fixnum | |||
There was a problem hiding this comment.
this line of documentation is now out of date:
The variable can either be a string or an array.
Also, it might be useful to raise when a string, number or array isn't passed as the second argument (what happens when a hash is passed, or undef (is it represented as a symbol)?
underscorgan
force-pushed
the
future_parser_fix
branch
from
2267f1c
to
7e0d255
Compare
| @@ -8,7 +8,7 @@ | |||
| module Puppet::Parser::Functions | |||
| newfunction(:member, :type => :rvalue, :doc => <<-EOS | |||
| This function determines if a variable is a member of an array. | |||
| The variable can either be a string or an array. | |||
| The variable can either be a string, fixnum, or array. | |||
There was a problem hiding this comment.
"either" implies one of two, should just be "The variable can be a string, fixnum, or array.")
underscorgan
force-pushed
the
future_parser_fix
branch
from
7e0d255
to
c5467cc
Compare
cmurphy
added a commit
that referenced
this pull request
Nov 17, 2014
Need to convert strings and fixnums to arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.