(MODULES-2071) Patch file_line provider to use multiple with after #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parameter multiple in function handle_create_with_after Without this, file_line resource without the `match` parameter but with the `after` param will throw an error if there are multiple matches for the after expression. This patch creates the handling for the `multiple` parameter in handle_create_with_after. This allows you to add a line after the `after` expression if it appears at multiple points in a file. Updated reference to `file_line` in the README to reflect that the multiple parameter can be set when using `after` and/or `match` as the matching regex.
|
The result of the test was: PASS I am a beta ci bot. I am probably lying to you. |
|
Hi @rmaika , thank you for your contribution! |
DavidS
added a commit
that referenced
this pull request
May 29, 2015
(MODULES-2071) Patch file_line provider to use multiple with after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this,
file_lineresource without thematchparameter but with theafterparam will throw an error if there are multiple matches for the after expression. This patch creates the handling for themultipleparameter in handle_create_with_after. This allows you to add a line after theafterexpression if it appears at multiple points in a file without specifying thematchparam.Updated reference to
file_linein the README to reflect that the multiple parameter can be set when usingafterand/ormatchas the matching regex.