New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_metadata_json function #483

Merged
merged 1 commit into from Jul 31, 2015

Conversation

Projects
None yet
4 participants
@nibalizer
Contributor

nibalizer commented Jul 9, 2015

This function loads the metadata.json into a puppet variable. This enables a number of neat things such as:

  • Which version of the module am I using? 2.x? 3.x?
  • Which author of the module am I using? puppetlabs? example42?
@raphink

This comment has been minimized.

Show comment
Hide comment
@raphink

raphink Jul 13, 2015

Member

👍

Member

raphink commented Jul 13, 2015

👍

@DavidS

This comment has been minimized.

Show comment
Hide comment
@DavidS

DavidS Jul 14, 2015

Contributor

Can we have a few unit tests which check error handling and the major interactions in the function?

Contributor

DavidS commented Jul 14, 2015

Can we have a few unit tests which check error handling and the major interactions in the function?

@DavidS

This comment has been minimized.

Show comment
Hide comment
@DavidS
Contributor

DavidS commented Jul 16, 2015

@nibalizer

This comment has been minimized.

Show comment
Hide comment
@nibalizer

nibalizer Jul 17, 2015

Contributor

Hi David, I've created some really basic tests. Since the function looks on the filesystem for a file I'm not sure exactly how to test this part.

Contributor

nibalizer commented Jul 17, 2015

Hi David, I've created some really basic tests. Since the function looks on the filesystem for a file I'm not sure exactly how to test this part.

Add load_metadata_json function
This function loads the metadata.json into a puppet variable. This enables a number of neat things such as:

* Which version of the module am I using? 2.x? 3.x?
* Which author of the module am I using? puppetlabs? example42?

hunner added a commit that referenced this pull request Jul 31, 2015

@hunner hunner merged commit e815da5 into puppetlabs:master Jul 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nibalizer

This comment has been minimized.

Show comment
Hide comment
@nibalizer

nibalizer Jul 31, 2015

Contributor

Thanks a bunch to @hunner for helping me with this for #puppethack

Contributor

nibalizer commented Jul 31, 2015

Thanks a bunch to @hunner for helping me with this for #puppethack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment