accept any case of boolean strings #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logicminds
force-pushed
the
case_insensitive
branch
from
882af28
to
ad7c56c
Compare
|
Hi Corey, this looks really useful! Please add a short note to the description of the function in the README. Cheers, David |
* previously the str2bool function did not accept 'TRUE' as a bool
type. This causes the function to now accept TRUE, FALSE strings
as a boolean type in order to be converted to a proper boolean.
* This would also cause Y,N, YES, NO to be accepted as boolean types
as well.
logicminds
force-pushed
the
case_insensitive
branch
from
ad7c56c
to
f2f2db4
Compare
|
Just updated the README and function description. |
tphoney
added a commit
that referenced
this pull request
Sep 9, 2015
accept any case of boolean strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type. This causes the function to now accept TRUE | FALSE strings
as a boolean type in order to be converted to a proper boolean.
as well.