Add validator for any IP address #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jdevesa. This looks pretty good. Can you add docs for this new function? |
|
👍 |
|
@bmjen Thanks!. Take a look at the second commit with the docs and tell me if is good enough |
| @@ -1230,3 +1263,4 @@ To report or research a bug with any part of this module, please go to | |||
| ##Contributors | |||
|
|
|||
| The list of contributors can be found at: https://github.com/puppetlabs/puppetlabs-stdlib/graphs/contributors | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this extra newline?
|
Thanks @jdevesa. Things look great. Can you make that last tiny edit and squash these 2 commits down to 1 and we look good to go! |
|
Sure @bmjen |
Provide a validator for IP addresses, regardless they are IPv4 or IPv6, and its documentation.
bmjen
added a commit
that referenced
this pull request
Nov 30, 2015
Add validator for any IP address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a validator for IP addresses, regardless they are IPv4 or IPv6