New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported data type error with rspec-puppet master #715

Merged
merged 1 commit into from Feb 20, 2017

Conversation

Projects
None yet
2 participants
@domcleal
Member

domcleal commented Feb 3, 2017

The symbol used in the value of the facts hash is not a valid type of
value for facts, and results in the following error since
rspec-puppet@d50acf0e.

Puppet::Error:
  Unsupported data type: 'Symbol'
# puppet/lib/puppet/parser/scope.rb:788:in `deep_freeze'
# puppet/lib/puppet/parser/scope.rb:781:in `block in deep_freeze'
# puppet/lib/puppet/parser/scope.rb:781:in `each'
# puppet/lib/puppet/parser/scope.rb:781:in `deep_freeze'
# puppet/lib/puppet/parser/scope.rb:764:in `set_facts'
# puppet/lib/puppet/parser/compiler.rb:850:in `set_node_parameters'
# puppet/lib/puppet/parser/compiler.rb:166:in `block (2 levels) in compile'
# puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
# puppet/lib/puppet/util/profiler.rb:51:in `profile'
# puppet/lib/puppet/parser/compiler.rb:166:in `block in compile'
# puppet/lib/puppet/context.rb:65:in `override'
# puppet/lib/puppet.rb:293:in `override'
# puppet/lib/puppet/parser/compiler.rb:162:in `compile'
# rspec-puppet/lib/rspec-puppet/example/function_example_group.rb:161:in `build_compiler'

The fact's presence doesn't change the behaviour, so remove it.

@domcleal domcleal force-pushed the domcleal:function-fact-freeze branch from 6a47e81 to c8c9ee6 Feb 4, 2017

Fix unsupported data type error with rspec-puppet master
The symbol used in the value of the facts hash is not a valid type of
value for facts, and results in the following error since
rspec-puppet@d50acf0e.

    Puppet::Error:
      Unsupported data type: 'Symbol'
    # puppet/lib/puppet/parser/scope.rb:788:in `deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:781:in `block in deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:781:in `each'
    # puppet/lib/puppet/parser/scope.rb:781:in `deep_freeze'
    # puppet/lib/puppet/parser/scope.rb:764:in `set_facts'
    # puppet/lib/puppet/parser/compiler.rb:850:in `set_node_parameters'
    # puppet/lib/puppet/parser/compiler.rb:166:in `block (2 levels) in compile'
    # puppet/lib/puppet/util/profiler/around_profiler.rb:58:in `profile'
    # puppet/lib/puppet/util/profiler.rb:51:in `profile'
    # puppet/lib/puppet/parser/compiler.rb:166:in `block in compile'
    # puppet/lib/puppet/context.rb:65:in `override'
    # puppet/lib/puppet.rb:293:in `override'
    # puppet/lib/puppet/parser/compiler.rb:162:in `compile'
    # rspec-puppet/lib/rspec-puppet/example/function_example_group.rb:161:in `build_compiler'

The fact's presence doesn't change the behaviour, so remove it.

@domcleal domcleal force-pushed the domcleal:function-fact-freeze branch from c8c9ee6 to 89a36c6 Feb 4, 2017

@DavidS DavidS merged commit e64a9d6 into puppetlabs:master Feb 20, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@DavidS

This comment has been minimized.

Contributor

DavidS commented Feb 20, 2017

Merging on red acceptance, since it is a unit test only change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment