Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alias spec error message expectation for PUP-7371 #743

Merged
merged 1 commit into from Mar 21, 2017

Conversation

@domcleal
Copy link
Member

@domcleal domcleal commented Mar 21, 2017

The fix for PUP-7371 adds the missing Undef into the error message
being tested in type aliases specs, fixing the following failure against
Puppet's master branch:

test::string rejects other values [] should fail to compile and raise an error matching /parameter 'value' expects a String/
Failure/Error: it { is_expected.to compile.and_raise_error(/parameter 'value' expects a String/) }
  error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Class[Test::String]: parameter 'value' expects a value of type Undef or String, got Array at line 2:1 on node example
# ./spec/aliases/string_spec.rb:27:in `block (5 levels) in <top (required)>'
The fix for PUP-7371 adds the missing `Undef` into the error message
being tested in type aliases specs, fixing the following failure against
Puppet's master branch:

    test::string rejects other values [] should fail to compile and raise an error matching /parameter 'value' expects a String/
    Failure/Error: it { is_expected.to compile.and_raise_error(/parameter 'value' expects a String/) }
      error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Class[Test::String]: parameter 'value' expects a value of type Undef or String, got Array at line 2:1 on node example
    # ./spec/aliases/string_spec.rb:27:in `block (5 levels) in <top (required)>'
@wilson208
Copy link
Contributor

@wilson208 wilson208 commented Mar 21, 2017

LGTM 👍

@wilson208 wilson208 merged commit 9a6a33e into puppetlabs:master Mar 21, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants