Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stdlib::Mode type #834

Merged
merged 1 commit into from
Nov 2, 2017
Merged

Add Stdlib::Mode type #834

merged 1 commit into from
Nov 2, 2017

Conversation

ghoneycutt
Copy link
Contributor

No description provided.

@ghoneycutt ghoneycutt force-pushed the mode_type branch 2 times, most recently from 402d343 to 5cf4931 Compare October 31, 2017 17:10
@ghoneycutt
Copy link
Contributor Author

I based my work off of the Unixpath type. Let me know if I'm missing anything.

@ghoneycutt ghoneycutt mentioned this pull request Oct 31, 2017
Merged
@ripienaar
Copy link

Mode is perhaps a bit generic? UnixFileMode or similar be better? or just FileMode if you want to eventually support other OS?

@ghoneycutt
Copy link
Contributor Author

Good idea, RI. I changed it to Filemode.

david22swan
david22swan approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like another +1

@david22swan david22swan merged commit ee12ea4 into puppetlabs:master Nov 2, 2017
@ghoneycutt
Copy link
Contributor Author

Thanks!

@ghoneycutt ghoneycutt deleted the mode_type branch November 2, 2017 14:50
@ghoneycutt
Copy link
Contributor Author

@david22swan could you please tag a new release with this functionality.

@david22swan
Copy link
Member

Release is currently going out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghoneycutt @ripienaar @david22swan @jordanbreen28