(MODULES-7024) Add 20-octet MAC addresses

[ananace]

Not quite sure if the best thing is to extend the MAC matcher, but since the 20-octet hardware address is the exact same format it feels like a good start.

[pmcmaw]

Closing and reopening to kick tests from an updated Travis test configuration that is now in puppetlabs-stdlib master.

[pmcmaw]

Would it be possible to add a test to confirm that this functionality works as expected. An example of testing this can be found here: https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/spec/acceptance/is_mac_address_spec.rb so if you extend them to include a 20-octet MAC address.

We would also like to thank you for taking time to contribute, it is much appreciated.

[ananace]

Tests have been added, though I didn't see anywhere that actively tested the Puppet type itself, only the is_mac_address function - which uses its own regex.

The AppVeyor build seems to have had some issues with testing fqdn_rotate though

[ananace]

Just to throw a ping at this, are there any examples for testing an actual type - and not a function? Or is it just a case of it being enough to test the is_mac_address function?

[pegasd]

@ananace There are! Check out spec/type_aliases directory - this is the best approach for testing custom types imo.