(MODULES-7181) Remove Stdlib::(Ipv4|IPv6|Ip_address) #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was 3 different data types for ip validation before this commit. This removes the Stdlib::(Ipv4|IPv6|Ip_address) data type in favour of Stdlib::IP::* as those are way more complete.
|
as the one that introduced those types, i agree, their should only be one interface for this [and the compat one]. The |
|
The upcoming 5.0.0 release could be a good time to introduce these backwards-incompatible changes. |
This commit includes changes to the README to redirect users to use a new function as this one has now been removed. -`Stdlib::Ipv4` -> `Stdlib::IP::Address::V4` -`Stdlib::Ipv6` -> `Stdlib::IP::Address::V6` -`Stdlib::Ip_address` -> `Stdlib::IP::Address'
|
@david22swan when merging can you ensure to squash and merge. There is a typo in my second commit. (Pressed enter and submitted by accident) |
|
Thank you for the PR @baurmatt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was 3 different data types for ip validation before this commit.
This removes the Stdlib::(Ipv4|IPv6|Ip_address) data type in favour of
Stdlib::IP::* as those are way more complete.