Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load https file into loadjson() and loadyaml() #918

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Load https file into loadjson() and loadyaml() #918

merged 1 commit into from
Jun 14, 2018

Conversation

jonnytdevops
Copy link
Contributor

@jonnytdevops jonnytdevops commented Jun 12, 2018 •
edited
Loading

This functionality is useful if one needs to interface their puppet manifest with external systems that expose hashes via JSON or YAML over HTTP(S).

@jonnytdevops jonnytdevops force-pushed the load_http branch 7 times, most recently from 03c95ae to 7ef6dcd Compare June 12, 2018 22:40
@david22swan
Copy link
Member

Running through adhoc: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/modules/view/linux/view/_adhoc/view/stdlib/

david22swan
david22swan approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed on adhoc
LGTM

@david22swan david22swan merged commit 0f02513 into puppetlabs:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@HelenCampbell HelenCampbell Awaiting requested review from HelenCampbell

@pmcmaw pmcmaw Awaiting requested review from pmcmaw

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnytdevops @david22swan