Showing with 1,547 additions and 1,528 deletions.
  1. +6 −2 .devcontainer/README.md
  2. +1 −1 .devcontainer/devcontainer.json
  3. +3 −1 .fixtures.yml
  4. +2 −2 .github/workflows/auto_release.yml
  5. +15 −0 .github/workflows/mend.yml
  6. +2 −2 .github/workflows/nightly.yml
  7. +2 −2 .github/workflows/pr_test.yml
  8. +2 −2 .github/workflows/release.yml
  9. +2 −2 .github/workflows/spec.yml
  10. +0 −36 .github/workflows/stale.yml
  11. +0 −7 .puppet-lint.rc
  12. +1 −8 .sync.yml
  13. +15 −0 CHANGELOG.md
  14. +24 −15 Gemfile
  15. +949 −953 REFERENCE.md
  16. +0 −7 Rakefile
  17. +6 −4 examples/catalina_attributes.pp
  18. +5 −5 examples/catalina_properties.pp
  19. +2 −2 examples/default_install_from_package.pp
  20. +2 −2 examples/default_install_from_source.pp
  21. +2 −2 examples/instance_with_context.pp
  22. +2 −2 examples/instance_with_listener.pp
  23. +2 −2 examples/instance_with_realm.pp
  24. +2 −2 examples/instance_with_role_and_user.pp
  25. +15 −15 examples/jsvc_install_from_source.pp
  26. +2 −2 examples/multiple_instances.pp
  27. +38 −6 manifests/config/context.pp
  28. +6 −6 manifests/config/context/environment.pp
  29. +7 −7 manifests/config/context/manager.pp
  30. +7 −7 manifests/config/context/parameter.pp
  31. +8 −8 manifests/config/context/resource.pp
  32. +8 −8 manifests/config/context/resourcelink.pp
  33. +7 −31 manifests/config/context/resources.pp
  34. +9 −9 manifests/config/context/valve.pp
  35. +4 −4 manifests/config/properties.pp
  36. +3 −3 manifests/config/properties/property.pp
  37. +12 −12 manifests/config/server.pp
  38. +9 −9 manifests/config/server/connector.pp
  39. +13 −13 manifests/config/server/context.pp
  40. +19 −18 manifests/config/server/engine.pp
  41. +9 −9 manifests/config/server/globalnamingresource.pp
  42. +6 −6 manifests/config/server/host.pp
  43. +7 −7 manifests/config/server/listener.pp
  44. +16 −16 manifests/config/server/realm.pp
  45. +13 −13 manifests/config/server/resources.pp
  46. +9 −9 manifests/config/server/service.pp
  47. +14 −14 manifests/config/server/tomcat_users.pp
  48. +14 −14 manifests/config/server/valve.pp
  49. +5 −5 manifests/init.pp
  50. +30 −26 manifests/install.pp
  51. +3 −3 manifests/install/package.pp
  52. +9 −9 manifests/install/source.pp
  53. +33 −33 manifests/instance.pp
  54. +4 −4 manifests/instance/copy_from_home.pp
  55. +2 −2 manifests/instance/dependencies.pp
  56. +15 −15 manifests/service.pp
  57. +15 −15 manifests/setenv/entry.pp
  58. +12 −12 manifests/war.pp
  59. +4 −8 metadata.json
  60. +1 −1 spec/acceptance/acceptance_1b_spec.rb
  61. +1 −1 spec/classes/init_spec.rb
  62. +6 −6 spec/classes/tomcat_spec.rb
  63. +2 −2 spec/defines/config/context/environment_spec.rb
  64. +2 −2 spec/defines/config/context/manager_spec.rb
  65. +2 −2 spec/defines/config/context/parameter_spec.rb
  66. +2 −2 spec/defines/config/context/resource_spec.rb
  67. +2 −2 spec/defines/config/context/resourcelink_spec.rb
  68. +10 −12 spec/defines/config/context/resources_spec.rb
  69. +4 −4 spec/defines/config/context/valve_spec.rb
  70. +30 −4 spec/defines/config/context_spec.rb
  71. +4 −4 spec/defines/config/server/connector_spec.rb
  72. +4 −4 spec/defines/config/server/context_spec.rb
  73. +4 −4 spec/defines/config/server/engine_spec.rb
  74. +2 −2 spec/defines/config/server/globalnamingresource_spec.rb
  75. +4 −4 spec/defines/config/server/host_spec.rb
  76. +4 −4 spec/defines/config/server/listener_spec.rb
  77. +4 −4 spec/defines/config/server/realm_spec.rb
  78. +4 −4 spec/defines/config/server/resources_spec.rb
  79. +4 −4 spec/defines/config/server/service_spec.rb
  80. +4 −4 spec/defines/config/server/tomcat_users_spec.rb
  81. +4 −4 spec/defines/config/server/valve_spec.rb
  82. +4 −4 spec/defines/config/server_spec.rb
  83. +1 −1 spec/defines/install_spec.rb
  84. +1 −1 spec/defines/instance_spec.rb
  85. +1 −1 spec/defines/service_spec.rb
  86. +1 −1 spec/defines/setenv/entry_spec.rb
  87. +1 −1 spec/defines/war_spec.rb
8 changes: 6 additions & 2 deletions .devcontainer/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,18 @@ https://github.com/microsoft/vscode-dev-containers/tree/v0.140.1/containers/pupp

// Set *default* container specific settings.json values on container create.
"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
"terminal.integrated.profiles.linux": {
"bash": {
"path": "bash",
}
}
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"puppet.puppet-vscode",
"rebornix.Ruby"
]
],

// Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [],
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"settings": {
"terminal.integrated.profiles.linux": {
"bash": {
"path": "bash",
"path": "bash"
}
}
},
Expand Down
4 changes: 3 additions & 1 deletion .fixtures.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ fixtures:
archive: "https://github.com/voxpupuli/puppet-archive.git"
augeas_core: "https://github.com/puppetlabs/puppetlabs-augeas_core.git"
facts: 'https://github.com/puppetlabs/puppetlabs-facts.git'
puppet_agent: 'https://github.com/puppetlabs/puppetlabs-puppet_agent.git'
puppet_agent:
repo: 'https://github.com/puppetlabs/puppetlabs-puppet_agent.git'
ref: v4.12.1
provision: 'https://github.com/puppetlabs/provision.git'

symlinks:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/auto_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ jobs:
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: "Checkout Source"
if: ${{ github.repository_owner == 'puppetlabs' }}
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: false

- name: "PDK Release prep"
uses: docker://puppet/iac_release:ci
uses: docker://puppet/pdk:2.6.1.0
with:
args: 'release prep --force'
env:
Expand Down
15 changes: 15 additions & 0 deletions .github/workflows/mend.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: "mend"

on:
pull_request:
branches:
- "main"
schedule:
- cron: "0 0 * * *"
workflow_dispatch:

jobs:

mend:
uses: "puppetlabs/cat-github-actions/.github/workflows/mend_ruby.yml@main"
secrets: "inherit"
4 changes: 2 additions & 2 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
echo STEP_ID=setup-environment >> $GITHUB_ENV
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3
if: ${{ github.repository_owner == 'puppetlabs' }}

- name: Activate Ruby 2.7
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Activate Ruby 2.7
uses: ruby/setup-ruby@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
echo STEP_ID=setup-environment >> $GITHUB_ENV
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3
if: ${{ github.repository_owner == 'puppetlabs' }}

- name: Activate Ruby 2.7
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
echo STEP_ID=${{ matrix.platforms.image }}-${{ matrix.collection }}-1 >> $GITHUB_ENV
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Activate Ruby 2.7
uses: ruby/setup-ruby@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
ref: ${{ github.ref }}
clean: true
Expand All @@ -33,7 +33,7 @@ jobs:
runs-on: ubuntu-20.04
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
ref: ${{ github.ref }}
clean: true
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
echo STEP_ID=setup-environment >> $GITHUB_ENV
echo STEP_START=$(date +%s) >> $GITHUB_ENV
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3
if: ${{ github.repository_owner == 'puppetlabs' }}

- name: Activate Ruby 2.7
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
job-status: ${{ job.status }}
matrix-key: ${{ env.SANITIZED_PUPPET_VERSION }}
- name: Checkout Source
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: "Activate Ruby ${{ matrix.ruby_version }}"
uses: ruby/setup-ruby@v1
Expand Down
36 changes: 0 additions & 36 deletions .github/workflows/stale.yml

This file was deleted.

7 changes: 0 additions & 7 deletions .puppet-lint.rc
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@
--relative
--no-parameter_types-check
--no-parameter_documentation-check
--no-topscope_variable-check
--no-top_scope_facts-check
--no-relative_classname_inclusion-check
--no-legacy_facts-check
--no-selector_inside_resource-check
--ignore-paths=examples/*.pp,vendor/**/*.pp,bundle/**/*.pp,pkg/**/*.pp,spec/**/*.pp
9 changes: 1 addition & 8 deletions .sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,11 @@ Rakefile:
- bundle/**/*.pp
- pkg/**/*.pp
- spec/**/*.pp
extra_disabled_lint_checks:
- parameter_types
- parameter_documentation
- topscope_variable
- top_scope_facts
- relative_classname_inclusion
- legacy_facts
- selector_inside_resource
Gemfile:
optional:
":development":
- gem: rspec-retry
version: '= 0.4.5'
platforms: ruby
- gem: github_changelog_generator
version: '= 1.15.2'
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,21 @@

All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org).

## [v6.4.0](https://github.com/puppetlabs/puppetlabs-tomcat/tree/v6.4.0) (2023-03-23)

[Full Changelog](https://github.com/puppetlabs/puppetlabs-tomcat/compare/v6.3.0...v6.4.0)

### Added

- \(CONT-366\) Syntax update [\#507](https://github.com/puppetlabs/puppetlabs-tomcat/pull/507) ([LukasAud](https://github.com/LukasAud))

### Fixed

- Update commons-daemon-native version to match Tomcat bundled version [\#510](https://github.com/puppetlabs/puppetlabs-tomcat/pull/510) ([uoe-pjackson](https://github.com/uoe-pjackson))
- Allow adding and removing attributes in Context \(\#502\) [\#503](https://github.com/puppetlabs/puppetlabs-tomcat/pull/503) ([uoe-pjackson](https://github.com/uoe-pjackson))
- Exclude name in resources [\#501](https://github.com/puppetlabs/puppetlabs-tomcat/pull/501) ([kobybr](https://github.com/kobybr))
- pdksync - \(CONT-189\) Remove support for RedHat6 / OracleLinux6 / Scientific6 [\#500](https://github.com/puppetlabs/puppetlabs-tomcat/pull/500) ([david22swan](https://github.com/david22swan))

## [v6.3.0](https://github.com/puppetlabs/puppetlabs-tomcat/tree/v6.3.0) (2022-09-12)

[Full Changelog](https://github.com/puppetlabs/puppetlabs-tomcat/compare/v6.2.0...v6.3.0)
Expand Down
39 changes: 24 additions & 15 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,33 @@ def location_for(place_or_version, fake_version = nil)
end
end

ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments
minor_version = ruby_version_segments[0..1].join('.')

group :development do
gem "json", '= 2.0.4', require: false if Gem::Requirement.create('~> 2.4.2').satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 2.8.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "puppet-module-posix-default-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
gem "puppet-module-posix-dev-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
gem "puppet-module-win-default-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "puppet-module-win-dev-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "voxpupuli-puppet-lint-plugins", '>= 3.0', require: false, platforms: [:ruby]
gem "rspec-retry", '= 0.4.5', require: false, platforms: [:ruby]
gem "github_changelog_generator", require: false
gem "json", '= 2.1.0', require: false if Gem::Requirement.create(['>= 2.5.0', '< 2.7.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.3.0', require: false if Gem::Requirement.create(['>= 2.7.0', '< 3.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.5.1', require: false if Gem::Requirement.create(['>= 3.0.0', '< 3.0.5']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.6.1', require: false if Gem::Requirement.create(['>= 3.1.0', '< 3.1.3']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "json", '= 2.6.3', require: false if Gem::Requirement.create(['>= 3.2.0', '< 4.0.0']).satisfied_by?(Gem::Version.new(RUBY_VERSION.dup))
gem "voxpupuli-puppet-lint-plugins", '~> 4.0', require: false
gem "facterdb", '~> 1.18', require: false
gem "metadata-json-lint", '>= 2.0.2', '< 4.0.0', require: false
gem "puppetlabs_spec_helper", '~> 5.0', require: false
gem "rspec-puppet-facts", '~> 2.0', require: false
gem "codecov", '~> 0.2', require: false
gem "dependency_checker", '~> 0.2', require: false
gem "parallel_tests", '~> 3.4', require: false
gem "pry", '~> 0.10', require: false
gem "simplecov-console", '~> 0.5', require: false
gem "puppet-debugger", '~> 1.0', require: false
gem "rubocop", '= 1.6.1', require: false
gem "rubocop-performance", '= 1.9.1', require: false
gem "rubocop-rspec", '= 2.0.1', require: false
gem "rb-readline", '= 0.5.5', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "rspec-retry", '= 0.4.5', require: false, platforms: [:ruby]
gem "github_changelog_generator", '= 1.15.2', require: false
end
group :system_tests do
gem "puppet-module-posix-system-r#{minor_version}", '~> 1.0', require: false, platforms: [:ruby]
gem "puppet-module-win-system-r#{minor_version}", '~> 1.0', require: false, platforms: [:mswin, :mingw, :x64_mingw]
gem "puppet_litmus", '< 1.0.0', require: false, platforms: [:ruby, :x64_mingw]
gem "serverspec", '~> 2.41', require: false
end

puppet_version = ENV['PUPPET_GEM_VERSION']
Expand Down
Loading